Skip to content

Commit

Permalink
Rename --experimental_remote_grpc_log to --remote_grpc_log (bazel…
Browse files Browse the repository at this point in the history
…build#18193)

GRPC logging has been in use since the start of REAPI application to bazel, and is sufficiently stable and supported by tools_remote/remote_client

RELNOTES: `--experimental_remote_grpc_log` has been renamed to `--remote_grpc_log`

Closes bazelbuild#18180.

PiperOrigin-RevId: 526633832
Change-Id: Ib3b06c303f39f1dd8e1eff3b5b4d4d146f148665

Co-authored-by: George Gensure <werkt0@gmail.com>
  • Loading branch information
keertk and werkt authored Apr 24, 2023
1 parent 2481bb2 commit bb37d0b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -379,11 +379,11 @@ public void beforeCommand(CommandEnvironment env) throws AbruptExitException {
}

ClientInterceptor loggingInterceptor = null;
if (remoteOptions.experimentalRemoteGrpcLog != null) {
if (remoteOptions.remoteGrpcLog != null) {
try {
rpcLogFile =
new AsynchronousFileOutputStream(
env.getWorkingDirectory().getRelative(remoteOptions.experimentalRemoteGrpcLog));
env.getWorkingDirectory().getRelative(remoteOptions.remoteGrpcLog));
} catch (IOException e) {
handleInitFailure(env, e, Code.RPC_LOG_FAILURE);
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,8 @@ public RemoteBuildEventUploadModeConverter() {
public boolean experimentalGuardAgainstConcurrentChanges;

@Option(
name = "experimental_remote_grpc_log",
name = "remote_grpc_log",
oldName = "experimental_remote_grpc_log",
defaultValue = "null",
category = "remote",
documentationCategory = OptionDocumentationCategory.REMOTE,
Expand All @@ -410,7 +411,7 @@ public RemoteBuildEventUploadModeConverter() {
+ "protobufs with each message prefixed by a varint denoting the size of the"
+ " following serialized protobuf message, as performed by the method "
+ "LogEntry.writeDelimitedTo(OutputStream).")
public PathFragment experimentalRemoteGrpcLog;
public PathFragment remoteGrpcLog;

@Option(
name = "incompatible_remote_symlinks",
Expand Down

0 comments on commit bb37d0b

Please sign in to comment.