This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Fixes a lack of checks in get_all_motion_states() #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this issue affected the Home Assistant component depending on this lib, issue: fwestenberg/reolink_dev#550
There was definitely an inconsistency between
get_all_motion_states()andget_motion_state()in this code: whileget_motion_state()checks the response from cameras/NVR, theget_all_motion_states()just blindly passed the response tojson.loads()(which in case of empty response lead to problems in Home Assistant), and never calledclear_token()which could be a source of Home Assistant problems too...I'm still testing these changes locally, maybe later I'll find some more fixes that still affect Home Assistant - but this one is definitely an issue that asks to be fixed, so I think it would be safe if you'd accept this pull-request...