Add support for unassigned/reserved CBOR simple values #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a SimpleValue type which is distinct from Go's numeric types. Add support for properly encoding and decoding all simple values, including 251 unassigned/reserved simple values. Improve support for simple values as map keys by making them distinct from uint64 values 0-255. CBOR simple values are a subset of major type 7 that is not floating-point. Only 4 simple values were previously supported by this codec: - false - true - null - undefined The other 251 simple values are unassigned or reserved by IANA.
This was referenced Oct 10, 2022
x448
reviewed
Oct 12, 2022
x448
approved these changes
Nov 14, 2022
|
Still fuzzing this PR. I'll merge it tonight if no problem is detected by fuzzing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds proper support for all CBOR simple values, including simple values unassigned/reserved by IANA.
Closes #372
Background
CBOR simple values are a subset of major type 7 that is not floating-point.
Only 4 simple values were previously supported by this CBOR codec:
The other 251 simple values are unassigned or reserved by IANA.
TODO
EDIT: I will update README in a separate PR.