Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NilContainersMode option #377

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

fxamacker
Copy link
Owner

Changes:

  • Moved NilContainersMode from decode.go to encode.go because it is only an encoding option.
  • Renamed NullForNil to NilContainerAsNull.
  • Renamed EmptyForNil to NilContainerAsEmpty.
  • Updated and added some comments.

- Moved NilContainersMode from decode.go to encode.go
  because it is only an encoding option.
- Renamed NullForNil to NilContainerAsNull.
- Renamed EmptyForNil to NilContainerAsEmpty.
- Updated and added some comments.
@fxamacker
Copy link
Owner Author

@x448 Can you please take a look if you have time?

Copy link
Contributor

@x448 x448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Passed brief fuzzing, etc.

@fxamacker fxamacker merged commit 3ef81e0 into master Dec 30, 2022
@fxamacker fxamacker deleted the fxamacker/refactor-nilcontainer-encoption branch January 2, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants