Make Decoder.Decode() return io.UnexpectedEOF instead of io.EOF if CBOR data item is truncated #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if CBOR data item was truncated and the underlying reader reached EOF, Decoder.Decode() returned io.EOF. This bug fix makes it return io.UnexpectedEOF because the CBOR data item was truncated when EOF was encountered.
x448
approved these changes
Dec 31, 2022
| } | ||
| return dec.Decode(v) |
There was a problem hiding this comment.
Good idea to replace recursive call with for-loop. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CBOR data item is truncated at EOF, then Decoder.Decode() should return io.UnexpectedEOF instead of io.EOF.
Closes #378