Add Decoder.Skip() to skip CBOR data item in CBOR Sequences (RFC 8742) #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decoding CBOR Sequences (RFC 8742), it can be useful to skip to the next CBOR data item without decoding. This change adds Decoder.Skip() which will skip to next CBOR data item (if there is any) otherwise it will return error such as io.EOF, io.UnexpectedEOF, etc.
x448
approved these changes
Jan 1, 2023
| } | ||
| } | ||
|
|
||
| func TestDecoderSkip(t *testing.T) { |
There was a problem hiding this comment.
LGTM. Nice work keeping coverage above 98%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decoding CBOR Sequences (RFC 8742), it can be useful to skip to the next CBOR data item without decoding.
This PR adds
Decoder.Skip()which will skip to next CBOR data item (if there is any) otherwise it will return error such asio.EOF,io.UnexpectedEOF, etc.Special thanks to @espoal and @x448 for their comments on this feature.
Closes #366