Fix panic when decoding CBOR nil to *cbor.SimpleValue
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxamacker
force-pushed
the
fxamacker/fix-decode-cbor-null-to-pointer
branch
2 times, most recently
from
4a2755d
to
942d6a1
Compare
x448
reviewed
Jan 1, 2024
x448
approved these changes
Jan 1, 2024
Unmarshalling CBOR nil or CBOR undefined into a Go pointer should always set the pointer to nil. This commit fixes crash bug when unmarshalling CBOR nil or CBOR undefined into *cbor.SimpleValue by setting the pointer to nil. Also, added more tests for decoding to uninitialized and initialized pointer values. Separately (not part of this commit), the fuzzer was updated to attempt unmarshaling to *cbor.SimpleValue.
fxamacker
force-pushed
the
fxamacker/fix-decode-cbor-null-to-pointer
branch
from
942d6a1
to
cdc043a
Compare
Probably v2.6.0 because they are new features merged and fuzzed already.
It's best to wait for release tag before deploying to production, but feel free to try using main branch anytime for tests, etc. BTW, I have at least 1 more bugfix to merge before tagging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460
Unmarshalling CBOR nil or CBOR undefined into a Go pointer should always set the pointer to nil.
This PR:
*cbor.SimpleValueby setting the pointer to nil.Separately (not part of this PR), the fuzzer was updated to attempt unmarshaling directly to
*cbor.SimpleValue.