Fix EncOption/DecOption unset fields on mode regurgitation. #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that DefaultMapType didn't survive the trip from DecOptions to DecMode and back. There are existing roundtrip tests for both DecOptions/DecMode and EncOptions/EncMode, but they also depend on being updated when new options are added. I've updated the existing tests so that they fail unless all fields have been set to a non-zero value, and set the fields that were missing in the implementation of EncOptions() and DecOptions(). Hopefully the updated tests will make it easy to avoid the same mistake in the future.
PR Was Proposed and Welcomed in Currently Open Issue
Checklist (for code PR only, ignore for docs PR)
Last line of each commit message should be in this format:
Signed-off-by: Firstname Lastname firstname.lastname@example.com
(see next section).
Certify the Developer's Certificate of Origin 1.1
the Developer Certificate of Origin 1.1.