Replace *errors.errorString with InadmissibleTagContentTypeError
#552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently *errors.errorString is returned when unmarshalling built-in tags (tag 0-3 and 21-23) with inadmissible content type. This commit adds InadmissibleTagContentTypeError and returns this error with the same error message as before when unmarshalling build-in tags with inadmissible content type.
fxamacker
force-pushed
the
fxamacker/add-InadmissibleTagContentTypeError
branch
from
752db06 to
b84b471
Compare
x448
approved these changes
Jun 9, 2024
fxamacker
changed the base branch from
fxamacker/improve-bytestringformat-dec-mode
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #551
Currently *errors.errorString is returned when unmarshalling built-in tags (tag 0-3 and 21-23) with inadmissible content type.
This PR adds
InadmissibleTagContentTypeErrorand returns it (instead of*errors.errorString) for inadmissible type for tag content.For compatibility,
InadmisibleTagContentTypeErrorreturns the same error message as before when unmarshalling build-in tags with inadmissible content type.See "Tag validity" in RFC 8949 Section 5.3.2 for more about "inadmissible type for tag content".