Fixed a bug with the MP4 parser #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the "wide" atom. Appended some extra carriage return characters at the end of the RTSP headers. These were missing.
|
Thank you very much ! I will review and merge your patch soon :) |
|
I'm not so sure about the RTSP headers modifications in this commit, but the "wide" atom fix is necessary. It's just a simple modification for the parser to accept an atom that has nothing in its body (like only the wide atom does, I suppose). |
fyhertz
pushed a commit
that referenced
this pull request
Sep 24, 2013
Fixed a bug with the MP4 parser, and a bug in the RTSP client
|
Merged ! Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might have to be split in two commits, but since they are small changes I just bundled them together.