Expense creation from Slack (both form as well as DE flow) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault fields are mandatory
* Initial expense api fixes * Using foreign currency and amount from form metadata * Initial working expense via slack * Changed amount -> claim_amount * Added locations support * Moved upsert expense to background task * Fixed edit expense * Fixed update expense issue * fixed project change issue and project clear selection * Caching project before bg task * Caching expense id and msg ts for edit expense * minor * Refactored expense payload creation function * Merged receipt attach flow Co-authored-by: shreyanshs7 <shreyanshss7@gmail.com>
jatzz10
approved these changes
May 11, 2022
There was a problem hiding this comment.
@shreyanshs7 added few minor comments - can you those once?
|
|
||
| fyle_expense = FyleExpense(user) | ||
|
|
||
| expense_id = 'txCCVGvNpDMM' |
There was a problem hiding this comment.
@shreyanshs7 please remove hard coded stuff
|
|
||
| slack_client = get_slack_client(team_id) | ||
|
|
||
| expense_id = 'txCCVGvNpDMM' |
| ) | ||
|
|
||
| return JsonResponse({}) | ||
|
|
There was a problem hiding this comment.
can add one more line space
|
|
||
|
|
||
| def handle_add_expense_to_report(self, slack_payload: Dict, user_id: str, team_id: str) -> JsonResponse: | ||
|
|
There was a problem hiding this comment.
can remove extra line space
* added expense de flow * Added try except block * Minor * Minor * Minor Co-authored-by: shreyanshs7 <shreyanshss7@gmail.com>
* Fix edit expense form modal bug * Minor change * More minor changes * Fix all the bugs
* Add trackers for expense creation from slack * Minor changes
jatzz10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.