Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict slack user to have only one fyle account link #57

Merged
merged 10 commits into from
Dec 29, 2021
Merged

Conversation

jatzz10
Copy link
Contributor

@jatzz10 jatzz10 commented Dec 23, 2021

Changes -

  • if user tries to link an already linked account in a different workspace, user will get a message like this -
    Screenshot 2021-12-28 at 2 17 30 PM

Clickup

@jatzz10 jatzz10 self-assigned this Dec 23, 2021
@@ -1,3 +1,4 @@
from logging import log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this, not needed. We already have a logger in libs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was done

# If the fyle user already exists, send a message to user indicating they've already
# linked their Fyle account in one of their slack workspace
team_name = fyle_user.slack_team.name
message = f'Hey buddy you\'ve already linked your *Fyle* account in this workspace `{team_name}` :rainbow:'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor message suggestion - Hey buddy you\'ve already linked your *Fyle* account in {workspace name} workspace
Also, can we indicate to the user that if they want to link their account to new workspace, they should unlink from the already linked one and link in the new workspace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was done

@jatzz10 jatzz10 merged commit 56d41d1 into master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants