Show in progress message for async operations #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatzz10
commented
Feb 11, 2022
| channel=user.slack_dm_channel_id, | ||
| blocks=notification_message, | ||
| ts=message_timestamp | ||
| ) |
There was a problem hiding this comment.
This is done because -
- if an error occurs while approving a report in slack, we notify in the same thread as of that approval message
- but we don't change the original notification message
- now, in our case, as soon as the user clicks on the approve cta,
- we change the approve cta to approving
- now, in case of an error, we will have to revert the cta name back to approve, so that the user can try approving again
That is why, the above changes are done
Screen.Recording.2022-02-11.at.12.12.41.PM.mov
jatzz10
commented
Feb 11, 2022
| user = utils.get_or_none(User, slack_user_id=user_id) | ||
|
|
||
| slack_client = slack_utils.get_slack_client(team_id) | ||
|
|
||
| # Text message if user hasn't linked Fyle account | ||
| text = 'Hey buddy, you haven\'t linked your Fyle account yet :face_with_head_bandage: \n' \ | ||
| 'Checkout home tab for `Link Your Fyle Account` to link your Slack with Fyle :zap:' | ||
| 'Checkout <slack://app?team={}&id={}&tab=home|home tab> for `Link Your Fyle Account` to link your Slack with Fyle :zap:'.format(team_id, settings.SLACK_APP_ID) |
There was a problem hiding this comment.
Adding deep link in the message so that user can be redirected to the app home tab after clicking on it
Screen.Recording.2022-02-11.at.1.33.13.PM.mov
jatzz10
commented
Feb 15, 2022
shreyanshss7
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup
Changes done -
Screen.Recording.2022-02-11.at.6.05.16.PM.mov
Screen.Recording.2022-02-11.at.6.07.54.PM.mov