-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable approvers to review report expenses from Slack itself #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatzz10
changed the title
Make few modifications in the report approval notification message
[Phase 1] Make few modifications in the report approval notification message
Mar 1, 2022
jatzz10
commented
Mar 1, 2022
shreyanshss7
reviewed
Mar 3, 2022
shreyanshss7
reviewed
Mar 3, 2022
shreyanshss7
approved these changes
Mar 3, 2022
…o Fyle-1xbz27r-22xbkzg
…-slack-app into Fyle-1xbz27r-22xbkzg
gokulk16
approved these changes
Mar 7, 2022
jatzz10
changed the title
[Phase 1] Make few modifications in the report approval notification message
Enable approvers to review report expenses from Slack itself
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As part of this 1st phase of this initiative, made few modifications in the report approval notifications message for approvers
Initiative - https://www.notion.so/fyleuniverse/Add-detailed-Report-View-for-report-approval-notifications-d5384286edf643d98b0cb408fc6962dd
ClickUp - https://app.clickup.com/t/1xbz27r
Screenshots
Note - Modal related changes will be raised separately in another PR