tests added for dashboard messages #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin1111
reviewed
Nov 10, 2022
tests/test_messages.py
Outdated
|
|
||
| def test_pre_authorization_message(self): | ||
| pre_authorization_message = authorization.messages.get_pre_authorization_message(MOCK_USERNAME, FYLE_STOPLIGHT_URL) | ||
| assert type(pre_authorization_message) is list |
There was a problem hiding this comment.
can we store the expected return value as fixture and assert with it?
There was a problem hiding this comment.
if you think asserting the whole message will be overkill, we can just check specific parts of it, for example
'text': 'Hey there *{}* :wave:'.format(user_name), you can check if text has the expected value
There was a problem hiding this comment.
will this work
for text_object in pre_authorization_message:
assert 'text' in text_object
There was a problem hiding this comment.
assert pre_authorization_message[0]['text'] == 'Hey there *fake_username* :wave:'
tests/test_messages.py
Outdated
|
|
||
| def test_get_pre_authorization_message(self): | ||
| pre_authorization_message = authorization.messages.get_pre_authorization_message(MOCK_USERNAME, MOCK_FYLE_OAUTH_URL) | ||
| assert 'type' in pre_authorization_message[0] |
tests/test_messages.py
Outdated
| 'url': MOCK_FYLE_OAUTH_URL | ||
| } | ||
| sent_back_reports_view = dashboard.messages.get_sent_back_reports_dashboard_view(mock_reports, 'INR') | ||
| assert type(sent_back_reports_view) is list |
There was a problem hiding this comment.
same, can assert important keys that involves amount, count, etc
ashwin1111
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added for authorization and dashboard of fyle slack UI.
Imrovement
dashboard's coverage -- 30% to 95%,
Total coverage -- 65% to 68%
Attesting the coverage report of files.
