What means MinSize() of Entry?

[gksrb4]

Checklist

• I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
• This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

The Fuction of MinSize() of Entry Widget always return same size. Although It different text data.
In my view, the size of the rendering should change if the amount of text or the number of lines is different, which means that MinSize() should return different sizes. However, in reality, it returns a fixed value. I'm not sure if this is intentional or a bug.

Because it always returns the same value, scroll.ScrollToBottom() is currently not working.

type ReadonlyMultilineEntry struct {
	widget.Entry
	LineCount int
}

func NewReadonlyMultilineEntry() *ReadonlyMultilineEntry {
	entry := &ReadonlyMultilineEntry{}
	entry.ExtendBaseWidget(entry)
	// entry.Wrapping = fyne.TextWrapBreak
	entry.TextStyle = fyne.TextStyle{Monospace: true}
	entry.MultiLine = true
	return entry
}

func GetTerminalWidget() *fyne.Container {
	entry := mywidget.NewReadonlyMultilineEntry()
	scroll := container.NewScroll(entry)
	scroll.SetMinSize(fyne.NewSize(400, 350))
	logWriter := NewLogWriter(entry, scroll, 100, 250*time.Millisecond)
	log.SetOutput(logWriter)
	header := container.NewHBox(
		layout.NewSpacer(),
		widget.NewButtonWithIcon("Clear", theme.ContentClearIcon(), func() {
			logWriter.Clear()
		}),
		widget.NewButtonWithIcon("Bottom", theme.MoveDownIcon(), func() {
			scroll.ScrollToBottom()
		}),
		widget.NewButtonWithIcon("Top", theme.MoveUpIcon(), func() {
			scroll.ScrollToTop()
		}),
	)
	scroll.ScrollToBottom()
	content := container.NewVBox(
		header,
		scroll,
	)
	return content
}

How to reproduce

testE := widget.Entry{
  Text:      "test\r\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\n",
  MultiLine: true,
}
s := testE.MinSize()
log.Debug("testE MinSize: %v", s)
testE2 := widget.Entry{
  Text:      "test\ntest\ntest\ntest\ntest\ntest\ntest\ntest",
  MultiLine: true,
}
s = testE2.MinSize()

2024/04/16 11:47:07.720598 DEBG: testE MinSize: {36.703125 73.234375}
2024/04/16 11:47:07.720598 DEBG: testE2 MinSize: {36.703125 73.234375}

Screenshots

No response

Example code

testE := widget.Entry{
  Text:      "test\r\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\n",
  MultiLine: true,
}
s := testE.MinSize()
log.Debug("testE MinSize: %v", s)
testE2 := widget.Entry{
  Text:      "test\ntest\ntest\ntest\ntest\ntest\ntest\ntest",
  MultiLine: true,
}
s = testE2.MinSize()

Fyne version

2.4.4

Go compiler version

1.22

Operating system and version

Windows 10

Additional Information

No response

[andydotxyz]

If you turn off scrolling then the returned minimum size will be different.
Items that have scrolling turned on will always return a minsize that represents the smallest area that is usable.

[gksrb4]

	// Scroll can be used to turn off the scrolling of our entry when Wrapping is WrapNone.
	//
	// Since: 2.4
	Scroll widget.ScrollDirection

entry.Wrapping = fyne.TextWrapBreak

testE := widget.Entry{
  Text:  "test\r\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\n\r\n",
  MultiLine: true,
  Wrapping:  fyne.TextWrapBreak,
}
s := testE.MinSize()
log.Debug("testE MinSize: %v", s)
testE2 := widget.Entry{
  Text:      "test\ntest\ntest\ntest\ntest\ntest\ntest\ntest",
  MultiLine: true,
  Wrapping:  fyne.TextWrapBreak,
}
s = testE2.MinSize()
log.Debug("testE2 MinSize: %v", s)

2024/04/24 11:37:25.842972 DEBG: testE MinSize: {36.703125 73.234375}
2024/04/24 11:37:25.843474 DEBG: testE2 MinSize: {36.703125 73.234375}

I turn off scroll of the entry. but, The function of Entry.MinSize() still return same size.

[gksrb4]

testE := widget.Entry{
Text:      "test\r\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\n\r\n",
MultiLine: true,
// Wrapping:  fyne.TextWrapWord,
}
s := testE.MinSize()
log.Debug("testE MinSize: %v", s)
testE2 := widget.Entry{
Text:      "test\ntest\ntest\ntest\ntest\ntest\ntest\ntest",
MultiLine: true,
Wrapping:  fyne.TextWrapWord,
}
s = testE2.MinSize()
log.Debug("testE2 MinSize: %v", s)
testTg := widget.NewTextGridFromString("test\r\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\n\r\n")
s2 := testTg.MinSize()
log.Debug("testGrid MinSize: %v", s2)
testTg = widget.NewTextGridFromString("test\r\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\n\r\n")
s2 = testTg.MinSize()
log.Debug("testGrid2 MinSize MinSize: %v", s2)

I was considering using TextGrid, but it seems unsuitable for a log viewer as it does not support drag and select functionality

[andydotxyz]

I turn off scroll of the entry. but, The function of Entry.MinSize() still return same size.

No, you didn't turn off scrolling.

[Jacalz]

Moving this to a discussion as it is a question. Please use the issue tracker for bugs and feature requests.

[gksrb4]

thanks, It's more appropriate.

[gksrb4]

Okay, I set the Scroll parameter to 3 to turn off scrolling.
I want to use widget.ScrollDirection but I can't import '"fyne.io/fyne/v2/internal/widget"' because of internal package.
so I used 3 to set enum.

testE := widget.Entry{
Text:      "test\r\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\n\r\n",
MultiLine: true,
Scroll:    3,
// Wrapping:  fyne.TextWrapWord,
}
s := testE.MinSize()
log.Debug("testE MinSize: %v", s)
testE2 := widget.Entry{
Text:      "test\ntest\ntest\ntest\ntest\ntest\ntest\ntest",
MultiLine: true,
Scroll:    3,
// Wrapping:  fyne.TextWrapWord,
}
s = testE2.MinSize()
log.Debug("testE2 MinSize: %v", s)
testTg := widget.NewTextGridFromString("test\r\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\n\r\n")
s2 := testTg.MinSize()
log.Debug("testGrid MinSize: %v", s2)
testTg = widget.NewTextGridFromString("test\r\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\ntest\n\r\n")
s2 = testTg.MinSize()
log.Debug("testGrid2 MinSize MinSize: %v", s2)

2024/04/25 10:17:37.957176 DEBG: testE MinSize: {40.6875 416.64062}
2024/04/25 10:17:37.957176 DEBG: testE2 MinSize: {40.6875 168.625}
2024/04/25 10:17:37.957176 DEBG: testGrid MinSize: {40 336}
2024/04/25 10:17:37.957176 DEBG: testGrid2 MinSize MinSize: {40 192}

[andydotxyz]

It's container.ScrollNone https://docs.fyne.io/api/v2.4/container/

[gksrb4]

thanks