Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/binding: Switch to strconv in converters where possible #1735

Closed
Jacalz opened this issue Jan 7, 2021 · 0 comments
Closed

data/binding: Switch to strconv in converters where possible #1735

Jacalz opened this issue Jan 7, 2021 · 0 comments
Labels
optimization Tickets that could help Fyne apps run faster

Comments

@Jacalz
Copy link
Member

Jacalz commented Jan 7, 2021

Is your feature request related to a problem? Please describe:

It was noted in a binding PR that the conventions were slow. I suggested that we move to using the strconv package where possible because it is much faster that using fmt for string conversions and parsing.

#1717 (comment)

Is it possible to construct a solution with the existing API?

Should be possible. Will need some tweaking to the code that generates the "semi-generic" (proper generics in Go would probably help) type bindings. It will probably not work for cases with custom formats, but should work for most other cases.

Describe the solution you'd like to see:

Move every possible converter to use strconv for better performance. Custom formatting can naturally use fmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Tickets that could help Fyne apps run faster
Projects
None yet
Development

No branches or pull requests

2 participants