-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data/binding: optimized convertion using strconv #2142
Conversation
Looks like a good change thanks. |
Here are the results of the benchmarks for this change. The benchmarks are adaptations of the corresponding tests with asserts removed. The metric are thus results of 4
In summary, conversions are about twice as fast, we are allocating about 20% less each time. I'd say that it is a pretty good improvement 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unsure if I should leave my quick and dirt benchmarks in or not. They are there now, but I can easily remove them if we think that's a better idea.
Description:
This updates the data bindings to use the
strconv
package instead offmt
for conversions, leading to improved performance (benchmarks to come). This is currently WIP and is just a proof of concept with generations scripts yet to have been updated to take this into effect.Fixes #1735
Checklist: