Kannada characters not rendering correctly #2654

ravihara · 2021-11-21T12:22:04Z

Describe the bug:

I was following the example given at https://developer.fyne.io/tour/binding/twoway. I changed my keyboard layout to Kannada-itrans. I'm using Ubuntu 20.04 LTS 64 bit system and have install ibus-m17n and fonts-indic packages. While running the application via go run main.go, after typing couple of characters, the application crashed with the following error.

panic: runtime error: slice bounds out of range [15:14]

goroutine 9 [running]:
fyne.io/fyne/v2/widget.(*RichText).insertAt(0xc000618000, 0xf, {0xc000353f30, 0x3})
	/home/ravihara/.asdf/installs/golang/1.17.3/packages/pkg/mod/fyne.io/fyne/v2@v2.1.1/widget/richtext.go:222 +0x2b8
fyne.io/fyne/v2/widget.(*Entry).TypedRune(0xc0001a4000, 0xccd)
	/home/ravihara/.asdf/installs/golang/1.17.3/packages/pkg/mod/fyne.io/fyne/v2@v2.1.1/widget/entry.go:743 +0x11b
fyne.io/fyne/v2/internal/driver/glfw.(*window).charInput.func1()
	/home/ravihara/.asdf/installs/golang/1.17.3/packages/pkg/mod/fyne.io/fyne/v2@v2.1.1/internal/driver/glfw/window.go:1226 +0x25
fyne.io/fyne/v2/internal/driver/common.(*Window).RunEventQueue(0xc00045c200)
	/home/ravihara/.asdf/installs/golang/1.17.3/packages/pkg/mod/fyne.io/fyne/v2@v2.1.1/internal/driver/common/window.go:58 +0x56
created by fyne.io/fyne/v2/internal/driver/glfw.(*gLDriver).createWindow.func1
	/home/ravihara/.asdf/installs/golang/1.17.3/packages/pkg/mod/fyne.io/fyne/v2@v2.1.1/internal/driver/glfw/window.go:1395 +0x15b
exit status 2

To Reproduce:

Steps to reproduce the behaviour:

Go to 'https://developer.fyne.io/tour/binding/twoway' and create a sample project as per the guide. In my case, the sample code was in main.go in main package.
Export the required font file so as to get the Kannada font to render properly in the InputEntry box
export FYNE_FONT=/usr/share/fonts/truetype/Gubbi/Gubbi.ttf
Run the fyne application using go run main.go
See error

Screenshots:

Example code:

Device (please complete the following information):

OS: Ubuntu Linux 20.04 LTS 64-Bit (x86-64)
Version: 20.04 LTS
Go version: 1.17.3
Fyne version: 2.1.1

The text was updated successfully, but these errors were encountered:

andydotxyz · 2021-11-21T15:35:18Z

Run the fyne application using go run main.go

See error

I think this is missing some steps - didn't you have to type something into one of the fields? It would be helpful to get the characters so we can replicate correctly.

ravihara · 2021-12-03T16:19:27Z

Run the fyne application using go run main.go

See error

I think this is missing some steps - didn't you have to type something into one of the fields? It would be helpful to get the characters so we can replicate correctly.

Yes. The issue happens once you start typing couple of Kannada (IN_Kn) characters. I use ibus-m17n engine with itrans keyboard layout for Kannada, in order to type the characters. An Example string in Kannada could be - ಕನ್ನಡ ಒಂದು ಸುಂದರ ಭಾಷೆ

andydotxyz · 2021-12-06T02:03:13Z

Is the font you are using this one: https://github.com/aravindavk/Gubbi?

ravihara · 2021-12-07T06:32:07Z

Is the font you are using this one: https://github.com/aravindavk/Gubbi?

Yes.. Do you see an issue in the font?

andydotxyz · 2021-12-08T01:29:17Z

It would be good if you could outline the specific steps required to replicate the crash - that way I can know if we have fixed the problem,

ravihara · 2021-12-13T07:03:11Z

It would be good if you could outline the specific steps required to replicate the crash - that way I can know if we have fixed the problem,

mkdir check-fyne
cd check-fyne
go mod init github.com/ravihara/check-fyne
go get fyne.io/fyne/v2
Create the file main.go with the code sample as given in https://developer.fyne.io/tour/binding/twoway
go mod tidy
export FYNE_FONT=/usr/share/fonts/truetype/Gubbi/Gubbi.ttf
go run main.go
Clear the type in the text box
Switch to Kannada (IN_kn) keyboard layout and start typing random characters. If you need a proper string type ಕನ್ನಡ ಒಂದು ಸುಂದರ ಭಾಷೆ

ravihara · 2021-12-13T07:06:31Z

Today I retried again and the app hung instead of crashing. When I tried running again, it went fine. In all the cases, the font rendering is not proper too.

andydotxyz · 2021-12-30T02:31:28Z

I think we need more details replication steps for:

Switch to Kannada (IN_kn) keyboard layout and start typing random characters. If you need a proper string type ಕನ್ನಡ ಒಂದು ಸುಂದರ ಭಾಷೆ

Because I tried and it seemed to work OK, so I am clearly missing something.

andydotxyz · 2022-01-04T17:17:15Z

Just for posterity this was the code that created the screenshot above:

package main

import (
	"fyne.io/fyne/v2"
	"fyne.io/fyne/v2/app"
	"fyne.io/fyne/v2/container"
	"fyne.io/fyne/v2/data/binding"
	"fyne.io/fyne/v2/widget"
)

func main() {
	a := app.New()
	w := a.NewWindow("Hello")

	str := binding.NewString()
	str.Set("ಕನ್ನಡ ಒಂದು ಸುಂದರ ಭಾಷೆ")

	e := widget.NewEntryWithData(str)
	w.SetContent(container.NewVBox(
		widget.NewLabelWithData(str),
		e,
	))

	w.Resize(fyne.NewSize(180, 20))
	w.ShowAndRun()
}

ravihara · 2022-01-07T06:21:31Z

Just for posterity this was the code that created the screenshot above:

package main

import (
	"fyne.io/fyne/v2"
	"fyne.io/fyne/v2/app"
	"fyne.io/fyne/v2/container"
	"fyne.io/fyne/v2/data/binding"
	"fyne.io/fyne/v2/widget"
)

func main() {
	a := app.New()
	w := a.NewWindow("Hello")

	str := binding.NewString()
	str.Set("ಕನ್ನಡ ಒಂದು ಸುಂದರ ಭಾಷೆ")

	e := widget.NewEntryWithData(str)
	w.SetContent(container.NewVBox(
		widget.NewLabelWithData(str),
		e,
	))

	w.Resize(fyne.NewSize(180, 20))
	w.ShowAndRun()
}

Hi, thanks for trying it out. As I mentioned in my last comment, I couldn't reproduce the crash error due to slice size, again. Now, the only issue that remains is the font rendering. You can easily compare the rendered output in the fyne app and how it renders in the github in the code snippet that you posted. I mean, the value of str.set(...) method. We may close this issue, if font-rendering is a separate problem space.

andydotxyz · 2022-01-13T01:21:58Z

You can easily compare the rendered output in the fyne app and how it renders in the github in the code snippet that you posted.

It is not as easy as you think - the string rendered in GitHub is system dependent, I do not normally have "Gubbi" font running, so I just see squares. If you want to compare rendering output please post screenshots so we can see exactly what you expect.

ravihara · 2022-01-13T12:22:25Z

You can easily compare the rendered output in the fyne app and how it renders in the github in the code snippet that you posted.

It is not as easy as you think - the string rendered in GitHub is system dependent, I do not normally have "Gubbi" font running, so I just see squares. If you want to compare rendering output please post screenshots so we can see exactly what you expect.

Sorry about that! i missed the point. Please find the screenshot of the Kannada font rendering for your reference. You may compare it with #2654 (comment) to understand the rendering issue.

andydotxyz · 2022-01-13T15:34:00Z

Ah, thank you. I now understand that this is a shaping issue.
We are working on this with the go-text project with the Gio toolkit and other font experts :).

ravihara · 2022-01-13T16:45:50Z

Ah, thank you. I now understand that this is a shaping issue. We are working on this with the go-text project with the Gio toolkit and other font experts :).

Cool! So, it might not be a direct fyne issue here right? If so, we can close the issue. 👍🏽

andydotxyz · 2022-01-13T16:52:16Z

Oh the fix needs to be in Fyne, but the problem is a large one and we are collaborating on the solution :).
We can leave this open and track the implementation.

andydotxyz · 2022-01-18T03:05:55Z

The go-text team are awesome and I'm excited to share this latest version.
It is a long way from a Fyne PR, but this shows it should be possible in our next release...

ravihara · 2022-01-30T14:07:23Z

The go-text team are awesome and I'm excited to share this latest version. It is a long way from a Fyne PR, but this shows it should be possible in our next release...

Cool! Thanks. Waiting for that to happen 👍🏽

andydotxyz · 2023-01-03T09:53:58Z

This was fixed in v2.3.0 :)

andydotxyz · 2023-01-04T21:50:11Z

Actually this may not yet be sorted - the rendering is in, but we have to set the region for shaping to work well - making it part of a wider localisation work in future release :(

ravihara · 2023-01-05T06:59:57Z

Actually this may not yet be sorted - the rendering is in, but we have to set the region for shaping to work well - making it part of a wider localisation work in future release :(

Thanks for taking it up @andydotxyz

andydotxyz · 2023-07-11T15:58:03Z

Please do test our develop branch - it uses a new test renderer @ravihara .
The region issue may still exist, but testing so far indicates that it is working quite well without additional hints.

ravihara · 2023-07-12T06:09:09Z

Hi @andydotxyz. Thanks for the update. I tried it with "develop" branch using go version 1.20.6. The results are still the same.

andydotxyz · 2023-07-22T22:08:21Z

OK, sorry about that. We will have to get the region hinting in then as part of the internationalisation work, which didn't make it into v2.4.0

Fixes #2654

andydotxyz · 2024-07-04T09:49:13Z

This is now working on develop branch. Using the string "ಕನ್ನಡ ಒಂದು Hello 🖥️" in the code above I get the following render:

Also worth noting, this did not require FYNE_FONT or a custom theme, as the system fonts are looked up now so this just worked :)

ravihara · 2024-07-07T08:16:01Z

This is now working on develop branch. Using the string "ಕನ್ನಡ ಒಂದು Hello 🖥️" in the code above I get the following render:

Also worth noting, this did not require FYNE_FONT or a custom theme, as the system fonts are looked up now so this just worked :)

Thanks @andydotxyz. Let me verify it in my local system.

ravihara · 2024-07-07T08:25:15Z

It's working fine with "develop" branch. Thanks @andydotxyz for the help.

andydotxyz · 2024-07-07T13:34:10Z

Thanks for confirming :)

ravihara added the unverified A bug that has been reported but not verified label Nov 21, 2021

andydotxyz added the information-needed Further information is requested label Nov 21, 2021

andydotxyz changed the title ~~Runtime error while typing Kannada characters~~ Kannada characters not rendering correctly Jan 13, 2022

andydotxyz closed this as completed Jan 3, 2023

andydotxyz reopened this Jan 4, 2023

andydotxyz added bug Something isn't working and removed unverified A bug that has been reported but not verified information-needed Further information is requested labels Jan 4, 2023

andydotxyz added this to the Dalwhinnie (April/May 2023) milestone Jan 9, 2023

andydotxyz modified the milestones: Dalwhinnie (2.4 - July 2023), "E" release, late 2023 Jul 22, 2023

andydotxyz added the blocker Items that would block a forthcoming release label Mar 29, 2024

andydotxyz mentioned this issue Mar 29, 2024

Support internationalisation #605

Closed

andydotxyz added a commit that referenced this issue Jul 4, 2024

Segment by more than just font faces

85c2e2a

Fixes #2654

andydotxyz closed this as completed Jul 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kannada characters not rendering correctly #2654

Kannada characters not rendering correctly #2654

ravihara commented Nov 21, 2021 •

edited

Loading

andydotxyz commented Nov 21, 2021

ravihara commented Dec 3, 2021 •

edited by Jacalz

Loading

andydotxyz commented Dec 6, 2021

ravihara commented Dec 7, 2021

andydotxyz commented Dec 8, 2021

ravihara commented Dec 13, 2021

ravihara commented Dec 13, 2021

andydotxyz commented Dec 30, 2021

andydotxyz commented Jan 4, 2022 •

edited

Loading

ravihara commented Jan 7, 2022

andydotxyz commented Jan 13, 2022

ravihara commented Jan 13, 2022 •

edited

Loading

andydotxyz commented Jan 13, 2022

ravihara commented Jan 13, 2022

andydotxyz commented Jan 13, 2022

andydotxyz commented Jan 18, 2022

ravihara commented Jan 30, 2022

andydotxyz commented Jan 3, 2023

andydotxyz commented Jan 4, 2023

ravihara commented Jan 5, 2023

andydotxyz commented Jul 11, 2023

ravihara commented Jul 12, 2023 •

edited

Loading

andydotxyz commented Jul 22, 2023

andydotxyz commented Jul 4, 2024 •

edited

Loading

ravihara commented Jul 7, 2024

ravihara commented Jul 7, 2024

andydotxyz commented Jul 7, 2024

Kannada characters not rendering correctly #2654

Kannada characters not rendering correctly #2654

Comments

ravihara commented Nov 21, 2021 • edited Loading

Describe the bug:

To Reproduce:

Screenshots:

Example code:

Device (please complete the following information):

andydotxyz commented Nov 21, 2021

ravihara commented Dec 3, 2021 • edited by Jacalz Loading

andydotxyz commented Dec 6, 2021

ravihara commented Dec 7, 2021

andydotxyz commented Dec 8, 2021

ravihara commented Dec 13, 2021

ravihara commented Dec 13, 2021

andydotxyz commented Dec 30, 2021

andydotxyz commented Jan 4, 2022 • edited Loading

ravihara commented Jan 7, 2022

andydotxyz commented Jan 13, 2022

ravihara commented Jan 13, 2022 • edited Loading

andydotxyz commented Jan 13, 2022

ravihara commented Jan 13, 2022

andydotxyz commented Jan 13, 2022

andydotxyz commented Jan 18, 2022

ravihara commented Jan 30, 2022

andydotxyz commented Jan 3, 2023

andydotxyz commented Jan 4, 2023

ravihara commented Jan 5, 2023

andydotxyz commented Jul 11, 2023

ravihara commented Jul 12, 2023 • edited Loading

andydotxyz commented Jul 22, 2023

andydotxyz commented Jul 4, 2024 • edited Loading

ravihara commented Jul 7, 2024

ravihara commented Jul 7, 2024

andydotxyz commented Jul 7, 2024

ravihara commented Nov 21, 2021 •

edited

Loading

ravihara commented Dec 3, 2021 •

edited by Jacalz

Loading

andydotxyz commented Jan 4, 2022 •

edited

Loading

ravihara commented Jan 13, 2022 •

edited

Loading

ravihara commented Jul 12, 2023 •

edited

Loading

andydotxyz commented Jul 4, 2024 •

edited

Loading