Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant justify-content properties in CSS for centered-container class #5045

Closed
2 tasks done
noazaj opened this issue Jul 31, 2024 · 1 comment
Closed
2 tasks done
Labels
unverified A bug that has been reported but not verified

Comments

@noazaj
Copy link

noazaj commented Jul 31, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

The CSS for the centered-container class in the HTML file contains two justify-content properties. The second justify-content property will override the first one, making the first one redundant and potentially causing confusion.

How to reproduce

  1. Go to the repository containing the HTML file. (fyne\cmd\fyne\internal\templates\data\index.html)
  2. Locate the centered-container class in the CSS.
  3. Observe that there are two justify-content properties in the class definition.
  4. Notice that the second justify-content property overrides the first one.

Screenshots

No response

Example code

.centered-container {
display: flex;
flex-direction: column;
justify-content: flex-start;
align-items: center;
justify-content: center; /* This line overrides the previous justify-content */
min-height: 100vh;
}

Fyne version

2.5

Go compiler version

1.22.5

Operating system and version

Windows 11

Additional Information

No response

@noazaj noazaj added the unverified A bug that has been reported but not verified label Jul 31, 2024
andydotxyz added a commit to andydotxyz/fyne that referenced this issue Jul 31, 2024
andydotxyz added a commit to andydotxyz/fyne that referenced this issue Jul 31, 2024
@andydotxyz
Copy link
Member

Thanks for the report, this will be fixed in v2.5.1

@andydotxyz andydotxyz added this to the E fixes (v2.5.x) milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unverified A bug that has been reported but not verified
Projects
None yet
Development

No branches or pull requests

2 participants