-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/card (retry) #1263
Feature/card (retry) #1263
Conversation
…xt with content and image header Any of these can be omitted as the tests verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress!
Re:
To what end? If you think every permutation of options should be tested please say so - I added the ones you thought were missing, and this list is additional to that. Do you also need subtitle with content, subtitle with image, what about with just title missing as well? |
Sorry, my initial list should have been more comprehensive to avoid a back and forth. I don't think we need every permutation, just the main ones a dev is expected to use. |
OK, I think If I add titles+image and all4 we should have pretty good coverage |
That should be everything now |
Description:
A basic card container with header, subheader, content and image - all optional.
We can add more to this later, such as the buttons (style challenges as they are depicted like hyperlink...?)
Deprecate Group in favour of CardContainer and use it in a few places where group was before.
Tests are just image comparison at this time as it's a pretty simple linear layout.
Checklist: