Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactoring of cli to use spf13/cobra #1312

Closed
wants to merge 6 commits into from
Closed

WIP: Refactoring of cli to use spf13/cobra #1312

wants to merge 6 commits into from

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Sep 14, 2020

Description:

This refractors the fyne cli command to use spf13/cobra for building the backbones of the application structure. This simplifies a lot of our homegrown cli code, makes it look a bit nicer and makes it easier to add new functionality in the future.

image

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.
  • Any breaking changes have a deprecation path or have been discussed.

@andydotxyz
Copy link
Member

Just skimming through can you please make sure that it's backwards compatible? On the surface it looks like "fyne version" may not work any more...

@Jacalz
Copy link
Member Author

Jacalz commented Sep 15, 2020

Yeah good catch there. Will change the versioning to behave like it used to, for now. Tried to keep as much of the original code as possible to avoid breakages and make reviewing easier.

Will make sure to test that everything works and is backwards compatible before marking this as ready. :)

@Jacalz
Copy link
Member Author

Jacalz commented Sep 15, 2020

TODO: Remind myself that dependencies need to be vendored. That is the reason for Travis failures.

@Jacalz
Copy link
Member Author

Jacalz commented Sep 15, 2020

Notes to myself:

  • Install is currently not working correctly
  • Should perhaps avoid printing usage in a few places
  • Get is currently not working
  • Some flags need better descriptions

@Jacalz
Copy link
Member Author

Jacalz commented Sep 18, 2020

This was deemed to not meet demands due to the strict posix compliance.

@Jacalz Jacalz closed this Sep 18, 2020
@Jacalz Jacalz deleted the cli-rewrite branch October 10, 2020 17:47
@Jacalz Jacalz mentioned this pull request Jan 24, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants