Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct row header width in widget.Table #4421

Closed
wants to merge 0 commits into from
Closed

Correct row header width in widget.Table #4421

wants to merge 0 commits into from

Conversation

Ju-B
Copy link
Contributor

@Ju-B Ju-B commented Nov 24, 2023

Description:

Allows to set width and height of headers using methods: SetColumnWidth and SetRowHeight with index -1

Fixes #(4370)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@Ju-B Ju-B marked this pull request as draft November 24, 2023 20:06
@coveralls
Copy link

coveralls commented Nov 24, 2023

Coverage Status

coverage: 65.094% (-0.002%) from 65.096%
when pulling dc34dad on Ju-B:master
into 4a18a7f on fyne-io:develop.

@Ju-B Ju-B marked this pull request as ready for review November 24, 2023 20:20
@andydotxyz
Copy link
Member

Thanks for your contribution. I think there is some cross-branch issues here though, lots of unrelated commits have been pulled in.

Also does this not break the default header size? The new headerSize cache will default to 0,0 won't it?

@Ju-B
Copy link
Contributor Author

Ju-B commented Nov 24, 2023 via email

@Ju-B Ju-B marked this pull request as draft November 28, 2023 16:05
@Ju-B Ju-B closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants