Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with ios17.4 #4741

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Conversation

andydotxyz
Copy link
Member

Latest Xcode breaks the build due to escalation of warnings to errors.
This also fixes related errors found at the time.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz andydotxyz added this to the v2.4.5 milestone Mar 25, 2024
@andydotxyz andydotxyz added the blocker Items that would block a forthcoming release label Mar 25, 2024
@andydotxyz andydotxyz changed the base branch from master to release/v2.4.x March 25, 2024 11:01
@atljoseph
Copy link

Getting these warnings in macOS Console during iOS simulation.
This actually happens on myDialog.Show().

Data type not yet set for stream blendingUIHomeScreen, please switch to APIs that take eventDataClass as a parameter.

Error acquiring assertion: <Error Domain=RBSAssertionErrorDomain Code=2 "Specified target process does not exist" UserInfo={NSLocalizedFailureReason=Specified target process does not exist}>

Scene FBSceneManager/sceneID:app.example.fudge-default update failed: <NSError: 0x600000d5e2b0; domain: FBSceneErrorDomain; code: 1 ("operation-failed"); "Scene update failed."> {
    NSUnderlyingError = <NSError: 0x600000c32c40; domain: FBWorkspace; code: 1; "Scene client is invalid.">;
}

Lemme know if you want additional logs.

@andydotxyz
Copy link
Member Author

Getting these warnings in macOS Console during iOS simulation.

Are you sure that's a 17.4 iOS simulator?

@coveralls
Copy link

Coverage Status

coverage: 65.412% (-0.02%) from 65.435%
when pulling 612e0a9 on andydotxyz:fix/ios17.4
into 64496b3 on fyne-io:release/v2.4.x.

@andydotxyz
Copy link
Member Author

That windows failure is the one that's fixed on the develop workflow

@andydotxyz andydotxyz merged commit e63fa5d into fyne-io:release/v2.4.x Mar 30, 2024
11 of 12 checks passed
@andydotxyz andydotxyz deleted the fix/ios17.4 branch March 30, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants