Correctly shape input before truncating #5014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for fyne-io#4998
|
What is the status of this PR - what's the underlying issue that needs to be resolved? I tried this out and it seems to be truncating the Japanese script way too early now: 
|
Yup, that's the issue, Before it was treating it as a full block of unshaped characters and now it splits it into runs correctly but it will wrap early if they are not all part of exactly the same character / font / face type - the related issue I have opened is go-text/typesetting#166 |
|
That should cover it now @dweymouth :) |
dweymouth
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #4998
Need to resolve an underlying issue before this can be correctly tested - current state breaks existing tests too
Checklist: