Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed v2.5.2 release #5188

Merged
merged 29 commits into from
Oct 11, 2024
Merged

Proposed v2.5.2 release #5188

merged 29 commits into from
Oct 11, 2024
+338 −232

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Oct 10, 2024 •
edited
Loading

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

williambrode and others added 26 commits October 10, 2024 12:02
@williambrode @andydotxyz
Fixes an issue where adjusting the tree and then making it visible wo…
80a7e87 
…uld hide elements until one was selected.
@dweymouth @andydotxyz
use float comparison within delta
7c74996
@andydotxyz
Correctly shape input before truncating
e9ec61c 
Partial fix for fyne-io#4998
@andydotxyz
Correctly count the runes in a multi-run wrap
2fa23de 
Fixes fyne-io#4998
@andydotxyz
Correct ellipse tests numbers
6b70dce
@andydotxyz
Actually remember the test window title when created in the normal ma…
7c2de55 
…nner

Fixes fyne-io#5116
@williambrode @andydotxyz
Avoid deadlock in button renderer by aquiring read lock twice.
a2536d8
@andydotxyz
More safety for theme watching
14ec458
@andydotxyz
missed web file
6a958c2
@andydotxyz
Improving border docs
329e884
@andydotxyz
Fix an indexing error on Darwin introduced some time ago
19d9c1e
@andydotxyz
widget.Entry: validate when pasting from clipboard
be4d8e5 
Fixes fyne-io#5058.
@andydotxyz
cache: use one lock/unclock cycle to remove expired items.
bf9f9c3 
Fixes fyne-io#5129.
@prifre @andydotxyz
Added translation using Weblate (Swedish)
c076fca
@prifre @andydotxyz
Translated using Weblate (Swedish)
20b07d5 
Currently translated at 100.0% (39 of 39 strings)

Translation: Fyne/Fyne
Translate-URL: https://hosted.weblate.org/projects/fyne/fyne/sv/
@flimzy @andydotxyz
Update root package GoDoc to include internal links
00390a8
@ErikKalkoken @andydotxyz
Improve doc strings for file dialogs
db5e9dd
@ErikKalkoken @andydotxyz
Further improve comments for file dialogs
1e2e1d7
@Jacalz @andydotxyz
Modernise CI infrastructure with Go 1.22
1b25c1f 
This mainly does two things:
- Uses Go 1.22 instead of 1.21 as the highest version (I don't have 1.23
  on Fedora 40 yet so did not want to bump to latest just yet).
- We now always pull the latest setup-go-faster action in v1 without
  having to manually change version.
@Jacalz @andydotxyz
Update CI and code to use Staticcheck v0.5.1
e17d488 
This fixes a few code errors that slipped through review (thankfully now
handled by Staticcheck for us) and makes sure we are using the latest
version.
@Jacalz @andydotxyz
Add a missing import
55deef8 
Haven't quite gotten used to Nvim yet ;)
@Jacalz @andydotxyz
Bump Go version in CI to 1.23
9f4d4eb 
This should be safer than ever given that some new features are
dependent on the version in go.mod.
@andydotxyz
Improved temp check for windows/msys
4954b75
@andydotxyz
Fix split in a theme override container
e15392c
@steampoweredtaco @andydotxyz
Fixes fyne-io#4758, set the correct parameter memory and size for Dwm…
8585225 
…SetWindowAttribute and DWMWA_USE_IMMERSIVE_DARK_MODE on windows.
@steampoweredtaco @andydotxyz
Fixes lint issues
bd39066
@andydotxyz andydotxyz changed the base branch from master to release/v2.5.x October 10, 2024 12:36
@andydotxyz
Missed changelog
d85a96d
@andydotxyz
Fix a logic error in test when picking which item to tap
bb4cc42 
It was finding the child before changing to the desired directory!
Jacalz
Jacalz requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have the changes that I made for improving theme lookups on Linux? I couldn't see it in the changelog but it seems like something that would be useful.

CHANGELOG.md Outdated

### Fixed

* Sometimes fyne fails to setup dark mode in Windows (#4758)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be "on Windows"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

@andydotxyz
Copy link
Member Author

Does this have the changes that I made for improving theme lookups on Linux? I couldn't see it in the changelog but it seems like something that would be useful.

Wasn't that resolved in 2.5.1?

@Jacalz
Copy link
Member

Jacalz commented Oct 11, 2024

Ah, right. Sorry 😅

@andydotxyz andydotxyz merged commit 040623c into fyne-io:release/v2.5.x Oct 11, 2024
10 of 11 checks passed
@andydotxyz andydotxyz deleted the release/v2.5.2 branch October 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@andydotxyz @Jacalz @williambrode @dweymouth @prifre @flimzy @ErikKalkoken @steampoweredtaco