Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure text and SVG textures re-rasterize when window is dragged to new monitor #5335

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dweymouth
Copy link
Contributor

Description:

A regression in 2.5.3 resulted in text and SVG rasterizations not re-rasterizing when the window was moved between monitors, resulting in blurriness if the window went from low DPI to high DPI.

Fixes #5323

Checklist:

  • Tests included. -- Tested manually
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.651% (+0.001%) from 59.65%
when pulling 528768e on dweymouth:fix-5323
into 0afa6a9 on fyne-io:develop.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't quite comment on the approach but I left a minor comment inline.

// Ensure textures re-rasterize at the new scale
cache.DeleteTextTexturesFor(w.canvas)
w.canvas.content.Refresh()
//return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think committing commented out code goes against our contribution guide. I guess that applies to the code below as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants