Merge pull request #543 from schmengler/fix-mtrand-seed

Fix mtrand seed
fzaninotto · Mar 30, 2015 · 6b1d646 · 6b1d646
2 parents 65a9d28 + 377bbd6
commit 6b1d646
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/Faker/Generator.php b/src/Faker/Generator.php
@@ -179,7 +179,11 @@ public function getProviders()
 
     public function seed($seed = null)
     {
-        mt_srand($seed);
+        if ($seed === null) {
+            mt_srand();
+        } else {
+            mt_srand($seed);
+        }
     }
 
     public function format($formatter, $arguments = array())

diff --git a/test/Faker/GeneratorTest.php b/test/Faker/GeneratorTest.php
@@ -105,6 +105,21 @@ public function testMagicCallCallsFormatWithArguments()
         $this->assertEquals('bazfoo', $generator->fooFormatterWithArguments('foo'));
     }
 
+    public function testSeed()
+    {
+        $generator = new Generator;
+
+        $generator->seed(0);
+        $mtRandWithSeedZero = mt_rand();
+        $generator->seed(0);
+        $this->assertEquals($mtRandWithSeedZero, mt_rand(), 'seed(0) should be deterministic.');
+
+        $generator->seed();
+        $mtRandWithoutSeed = mt_rand();
+        $this->assertNotEquals($mtRandWithSeedZero, $mtRandWithoutSeed, 'seed() should be different than seed(0)');
+        $generator->seed();
+        $this->assertNotEquals($mtRandWithoutSeed, mt_rand(), 'seed() should not be deterministic.');
+    }
 }
 
 class FooProvider