Merge pull request #1400 from hppycoder/master

VISA retired the 13 digit PAN moved to new cardParams
fzaninotto · Jan 15, 2018 · b393800 · b393800
2 parents 251ec16 + 2d9e5db
commit b393800
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 12 deletions.
diff --git a/src/Faker/Provider/Payment.php b/src/Faker/Provider/Payment.php
@@ -12,7 +12,7 @@ class Payment extends Base
     protected static $cardVendors = array(
         'Visa', 'Visa', 'Visa', 'Visa', 'Visa',
         'MasterCard', 'MasterCard', 'MasterCard', 'MasterCard', 'MasterCard',
-        'American Express', 'Discover Card'
+        'American Express', 'Discover Card', 'Visa Retired'
     );
 
     /**
@@ -22,25 +22,27 @@ class Payment extends Base
      */
     protected static $cardParams = array(
         'Visa' => array(
-            "4539########",
             "4539###########",
-            "4556########",
             "4556###########",
-            "4916########",
             "4916###########",
-            "4532########",
             "4532###########",
-            "4929########",
             "4929###########",
-            "40240071####",
             "40240071#######",
-            "4485########",
             "4485###########",
-            "4716########",
             "4716###########",
-            "4###########",
             "4##############"
         ),
+        'Visa Retired' => array(
+            "4539########",
+            "4556########",
+            "4916########",
+            "4532########",
+            "4929########",
+            "40240071####",
+            "4485########",
+            "4716########",
+            "4###########",
+        ),
         'MasterCard' => array(
             "2221###########",
             "23#############",

diff --git a/test/Faker/Provider/PaymentTest.php b/test/Faker/Provider/PaymentTest.php
@@ -48,14 +48,15 @@ public function loadLocalProviders($locale)
 
     public function testCreditCardTypeReturnsValidVendorName()
     {
-        $this->assertContains($this->faker->creditCardType, array('Visa', 'MasterCard', 'American Express', 'Discover Card'));
+        $this->assertContains($this->faker->creditCardType, array('Visa', 'Visa Retired', 'MasterCard', 'American Express', 'Discover Card'));
     }
 
     public function creditCardNumberProvider()
     {
         return array(
             array('Discover Card', '/^6011\d{12}$/'),
-            array('Visa', '/^4\d{12,15}$/'),
+            array('Visa', '/^4\d{15}$/'),
+            array('Visa Retired', '/^4\d{12}$/'),
             array('MasterCard', '/^(5[1-5]|2[2-7])\d{14}$/')
         );
     }