Estonian names #1461
Estonian names #1461
Conversation
|
Please close and reopen this PR to build in Travis again |
|
I just restarted the build on Travis |
src/Faker/Provider/et_EE/Person.php
Outdated
| * @link https://news.err.ee/114745/most-popular-baby-names-of-2014 | ||
| */ | ||
| protected static $firstNameMale = array( | ||
| 'Rasmus', 'Artjom', 'Robin', 'Martin', 'Oliver', 'Romet', 'Sebastian', 'Robert', |
There was a problem hiding this comment.
This dataset is too small, please look for a (public) dataset of at least 100 names. Oh, and please order alphabetically, and split line by capital letter/
src/Faker/Provider/et_EE/Person.php
Outdated
| * @link https://news.err.ee/114745/most-popular-baby-names-of-2014 | ||
| */ | ||
| protected static $firstNameFemale = array( | ||
| 'Sofia', 'Eliise', 'Maria', 'Mia', 'Lisandra', 'Mirtel', 'Sandra', 'Emma', 'Laura', |
| ); | ||
|
|
||
| /** | ||
| * @link https://en.wikipedia.org/wiki/Category:Estonian-language_surnames |
There was a problem hiding this comment.
From what I understand, it's based on the articles on Wikipedia about Estonian people. How is that representative?
|
@fzaninotto Hey, I've added more names/surnames from Estonian department of Statistics, but they do provide only top50 for free, extra is paid. Though news.err.ee is one of the most popular news agency in Estonia and I've check wikipedia source for surnames - all of them refers to some real Estonian so it is quite representative. |
|
Hey @fzaninotto again, so I've asked stat.ee to send me a top100 and they actually did, so I have accumulated all the data I've gathered and updated PR with addition. |
|
@fzaninotto is this going to be reviewed? if no please close it. |
|
@much-rebel content wise this looks fine. Could you please cleanup your commit history so we will have a single solid commit with your changes? |
|
@pimjansen I don't mind the extra commits, besides you have the ability to squash and merge in GitHub. |
No description provided.