Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

add phone numer format #1506

Merged
merged 3 commits into from
Jun 18, 2018
Merged

add phone numer format #1506

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06810ec
add phone numer format
Enosh-Yu Jun 14, 2018
8b60d2b
modified phone number format
Enosh-Yu Jun 15, 2018
bf1714a
modify phone number format and document ko_KR phone number format in …
Enosh-Yu Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion src/Faker/Provider/ko_KR/PhoneNumber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,51 @@

class PhoneNumber extends \Faker\Provider\PhoneNumber
{
//reference : https://ko.wikipedia.org/wiki/%EB%8C%80%ED%95%9C%EB%AF%BC%EA%B5%AD%EC%9D%98_%EC%A0%84%ED%99%94%EB%B2%88%ED%98%B8_%EC%B2%B4%EA%B3%84

protected static $formats = array(
'010-####-####',
//local area phone format
'070-####-####',
'02-####-####',
'03#-####-####',
'04#-####-####',
'05#-####-####',
'06#-####-####',

//cell phone format
'010-####-####',

//others: Intelligent Network(기간통신사업자)
'1588-####',
'1577-####',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to the way randomElement works, these formats will be randomly picked way more often than the others. I suggest you use an intermediate formatter for those to avoid this distortion.

'1899-####',
'1544-####',
'1644-####',
'1661-####',
'1566-####',
'1600-####',
'1670-####',
'1688-####',
'1666-####',
'1599-####',
'1877-####',
'1855-####',
'1800-####',
);

public function localAreaPhoneNumber()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you add a new formatter, you must document it in the README

{
$format = self::randomElement(array_slice(static::$formats, 0, 6));

return self::numerify($this->generator->parse($format));
}



public function cellPhoneNumber()
{
$format = self::randomElement(array_slice(static::$formats, 6, 1));

return self::numerify($this->generator->parse($format));
}
}