This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Restore a random seed when the Generator is destroyed #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, the `mt_rand` seed could stay at the very same values, and so break all other usage to `mt_rand`.
|
ping @fzaninotto (this is an easy pick) |
fzaninotto
approved these changes
Nov 20, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, the
mt_randseed could stay at the very samevalue, and so break all other usages to
mt_rand.Oh, We had really hard time to find this bug :)
We are using Faker in our test suite, and we get a really strange
behavior : some entity were generated with the exact same UUID.
ATM, our implement of UUID generation is based on
mt_rand.Anyway, we found that Faker modifies the seed and let it to the same
value. So with this patch, we restore the seed to a random value.
And eveything goes fine now.