Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

fix austrian postal codes starting with invalid 0 #1545

Merged
merged 1 commit into from
Aug 25, 2019

Conversation

mpge
Copy link
Contributor

@mpge mpge commented Aug 11, 2018

Temp fix for #1544 - should probably implement more strict values in the future

Temp fix for fzaninotto#1544 - should probably implement more strict values in the future
@ppelgrims
Copy link
Contributor

There seems to have been a problem with Travis. Could you close and reopen this PR in order for it to run again? Tests will probably pass after that.

@mpge
Copy link
Contributor Author

mpge commented Sep 4, 2018

@ppelgrims for sure!

@mpge mpge closed this Sep 4, 2018
@mpge mpge reopened this Sep 4, 2018
Copy link
Contributor

@pimjansen pimjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would want to accept this change for now even though the content could be not 100% valid combination wise. But the first 0 prefix could break your test implementations.

So thanks for providing this fix

Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz merged commit c89e3f6 into fzaninotto:master Aug 25, 2019
@localheinz
Copy link
Contributor

Thank you, @mpge, @pimjansen, and @ppelgrims!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants