Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Updated information #1579

Closed
wants to merge 1 commit into from
Closed

Updated information #1579

wants to merge 1 commit into from

Conversation

goszowski
Copy link
Contributor

  1. Deleted email domains, blocked in Ukraine
  2. Added one new email domain
  3. Added new domain extension

1. Deleted email domains, blocked in Ukraine
2. Added one new email domain
3. Added new domain extension
Copy link
Contributor

@ppelgrims ppelgrims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR but even though this is a completely valid PR, it adds very low value. This package follows semantic versioning, current releases are minor ones. This enforces backwards-compatible bug fixes, changing existing data sets might break things for other users. From contributing:

Avoid changing existing sets of data. Some developers use Faker with seeding for unit tests ; changing the data makes their tests fail.

@fzaninotto
Copy link
Owner

I'm closing this bone because, as @ppelgrims said, it breaks existing code without adding much value in return. Feel free to reopen if you can provide more data.

@fzaninotto fzaninotto closed this Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants