Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Fix Dutch typo #1580

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Fix Dutch typo #1580

merged 1 commit into from
Sep 18, 2018

Conversation

gizburdt
Copy link
Contributor

I saw my surname in the faked data, but it is misspelled. The misspelled version doesn't exist in The Netherlands.

I saw my surname in the faked data, but it is misspelled. The misspelled version doesn't exist in The Netherlands.
Copy link
Contributor

@ppelgrims ppelgrims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR but even though this is a completely valid PR, it adds very low value. This package follows semantic versioning, current releases are minor ones. This enforces backwards-compatible bug fixes, changing existing data sets might break things for other users. From contributing:
Avoid changing existing sets of data. Some developers use Faker with seeding for unit tests ; changing the data makes their tests fail.

@gizburdt
Copy link
Contributor Author

All clear, thanks for the reply :)

@fzaninotto
Copy link
Owner

@ppelgrims I think this change is valid. It will only break tests in very rare cases (not all cases based on Dutch names). So I'm going to merge it. Thanks!

@fzaninotto fzaninotto merged commit 10cc47a into fzaninotto:master Sep 18, 2018
@ppelgrims
Copy link
Contributor

Yeah, I'm not sure how strict this is to be enforced. Anyway, nice work @gizburdt !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants