Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Bug Fix en_SG mobile number generation #1658

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Bug Fix en_SG mobile number generation #1658

merged 4 commits into from
Sep 17, 2019

Conversation

ziming
Copy link
Contributor

@ziming ziming commented Feb 8, 2019

Singapore mobile number only starts with 8 or 9. Not 7. The 2nd digit is never a 9 as well

See: http://en.wikipedia.org/wiki/Telephone_numbers_in_Singapore#Numbering_plan

Hope it helps!

8zxx xxxx - Mobile and Data Services

9yxx xxxx - Mobile, Data Services and Pager (until May 2012)

Which also means:

8[1-8]xx xxxx - Mobile and Data Services

9[0-8]xx xxxx - Mobile, Data Services and Pager (until May 2012)

x denotes 0 to 9
y denotes 0 to 8 only
z denotes 1 to 8 only

@ziming ziming changed the title Fix SG mobile number generation Fix en_SG mobile number generation Feb 8, 2019
@ziming ziming changed the title Fix en_SG mobile number generation Bug Fix en_SG mobile number generation Sep 9, 2019
@ziming
Copy link
Contributor Author

ziming commented Sep 9, 2019

Hmm. How do I add the bug label? @fzaninotto

@pimjansen pimjansen merged commit 63644ac into fzaninotto:master Sep 17, 2019
@pimjansen
Copy link
Contributor

Thanks for your contribution!

@ziming ziming deleted the fix-sg-mobile branch March 7, 2020 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants