This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
PHP 7.4 compatibility #1748
Merged
PHP 7.4 compatibility #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHP 7.4 is available in Travis as |
|
@NFarrington then the nightly would still work fine as well untill 7.4 is there as stable |
fzaninotto
approved these changes
Aug 23, 2019
stevegrunwell
added a commit
to stevegrunwell/pupper
that referenced
this pull request
Oct 6, 2019
Faker has been switched to dev-master for the time being, as the PHP 7.4 compatibility hasn't yet been tagged in a release (see fzaninotto/Faker#1748) and running 1.8 with phpdbg (e.g. `composer test-coverage` is resulting in a ton of errors related to `implode()`: > implode(): Passing glue string after array is deprecated. Swap the parameters
Closed
taylorotwell
pushed a commit
to laravel/laravel
that referenced
this pull request
Jan 31, 2020
Bumping `fzaninotto/faker` version to support PHP 7.4, especially when running composer with `--prefer-lowest` flag. PRs related to version `^1.9.1`: * fzaninotto/Faker#1748 * fzaninotto/Faker#1843
socheatsok78
pushed a commit
to pp-spaces/laravel
that referenced
this pull request
Feb 23, 2020
Bumping `fzaninotto/faker` version to support PHP 7.4, especially when running composer with `--prefer-lowest` flag. PRs related to version `^1.9.1`: * fzaninotto/Faker#1748 * fzaninotto/Faker#1843
gomasy
pushed a commit
to gomasy/bookshelf
that referenced
this pull request
Mar 4, 2020
Bumping `fzaninotto/faker` version to support PHP 7.4, especially when running composer with `--prefer-lowest` flag. PRs related to version `^1.9.1`: * fzaninotto/Faker#1748 * fzaninotto/Faker#1843
gomasy
added a commit
to gomasy/bookshelf
that referenced
this pull request
Mar 4, 2020
* Bump fzaninotto/faker version to support PHP 7.4 (#5218) Bumping `fzaninotto/faker` version to support PHP 7.4, especially when running composer with `--prefer-lowest` flag. PRs related to version `^1.9.1`: * fzaninotto/Faker#1748 * fzaninotto/Faker#1843 * Remove redundant default attributes from phpunit.xml (#5233) * Update dependencies Co-authored-by: ARCANEDEV <arcanedev.maroc@gmail.com> Co-authored-by: Sjors Ottjes <sjorsottjes@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PHP 7.4 the implode methods will break:
implode(): Passing glue string after array is deprecated. Swap the parametersI also updated travis to match 7.3. However there is no 7.4 env available in Travis yet as far as i know