This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Fix: Allow nightly builds to fail #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@localheinz i think we should keep the nightly in there as well for any future changes isnt it? Since 7.5 and 8.0 will also be there at some point. Further we could also test for the next patch releases on php on the nightly builds as well |
localheinz
changed the title
|
I updated the PR to allow |
|
@localheinz yeah its better indeed i think. We can then easily add 7.4 in november when its released where now the 7.4 snapshot and the nightly wouldnt be that much difference i suppose |
fzaninotto
approved these changes
Aug 25, 2019
pimjansen
approved these changes
Aug 25, 2019
|
Thank you, @fzaninotto and @pimjansen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
nightlybuilds to failSomewhat related to #1758, as 3rd-party extensions (such as Xdebug) are not installed on nightly builds (see https://docs.travis-ci.com/user/languages/php/#nightly-builds).