Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Enhancement: Introduce build and help targets #1761

Merged
merged 4 commits into from
Aug 25, 2019

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Aug 24, 2019

This PR

  • declares all phony targets at the start of the Makefile
  • keeps other targets sorted by name
  • introduces a build target which depends on fix and test
  • introduces a help target which displays a list of targets with descriptions (when they have been provided as comments)

@fzaninotto
Copy link
Owner

I'd rather have make display a lost of all available commands. See https://github.com/marmelab/react-admin/blob/810e2e4f76190caa13c3d812056eff2b946007b9/Makefile#L1-L4 for an example.

@localheinz localheinz changed the title Enhancement: Introduce target that depends on sniff and make Enhancement: Introduce build and help targets Aug 25, 2019
@localheinz
Copy link
Contributor Author

@fzaninotto

That's a great idea - I have adjusted this PR accordingly!

@pimjansen pimjansen merged commit aa6ea48 into fzaninotto:master Aug 25, 2019
@localheinz localheinz deleted the feature/make branch August 25, 2019 21:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants