This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Enhancement: Update squizlabs/php_codesniffer #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/php-codesniffer
branch
from
07c4bf9
to
a37eb87
Compare
pimjansen
reviewed
Aug 24, 2019
There was a problem hiding this comment.
@localheinz did you already try PSR12 since if im correct it is already finalized. This way we are also fine for the future. The rest looks great 👌🏻
|
Looks like some more work is needed upstream, see squizlabs/PHP_CodeSniffer#750! |
pimjansen
approved these changes
Aug 24, 2019
fzaninotto
approved these changes
Aug 25, 2019
|
Great! |
|
Thank you, @fzaninotto and @pimjansen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
squizlabs/php_codesnifferfixtarget toMakefilemake fix💁♂ For reference, see squizlabs/PHP_CodeSniffer@1.5.6...2.9.2.