Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Enhancement: Consistently use composer package name for link content #1770

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Aug 26, 2019

This PR

  • consistently uses the composer package name as link content for links to 3rd party libraries

💁‍♂ I'd also suggest

  • consistently liking to GitHub repositories (rather than in at least one example, linking to https://packagist.org)
  • perhaps removing abandoned packages
  • splitting the list (perhaps into sections Framework Integrations and Providers)
  • keeping the list(s) sorted by package name

We could also start adding GitHub issue and pull request templates, and add a template for adding a library that gives suggestions, what do you think?

@pimjansen
Copy link
Contributor

pimjansen commented Aug 26, 2019

@localheinz agree with all the bullets. I think the templates could really help. Also the template how to report a bug since we miss a lot of code snippets and such.

Will you take that in this PR or split it up?

@localheinz
Copy link
Contributor Author

@pimjansen

Personally, I'd prefer to keep the scope of pull requests limited to one change - what do you think?

@pimjansen
Copy link
Contributor

@pimjansen

Personally, I'd prefer to keep the scope of pull requests limited to one change - what do you think?

Totally agree, was just wondering since you commented it here. So this PR further looks ok!

Copy link
Owner

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK for all, except

  • removing abandoned packages

We can't commit on regularly checking if all those packages are still maintained.

Copy link
Owner

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, wrong button

@fzaninotto fzaninotto merged commit e2602c4 into fzaninotto:master Aug 26, 2019
@localheinz localheinz deleted the feature/package-name branch August 26, 2019 09:41
@localheinz
Copy link
Contributor Author

Thank you, @fzaninotto and @pimjansen!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants