-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Conversation
This will add hslColor and hslColorAsArray for ColorProvider Should solve #1720
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
One more thing though before I can approve: Can you update readme.md
, please?
@@ -113,4 +113,26 @@ public static function colorName() | |||
{ | |||
return static::randomElement(static::$allColorNames); | |||
} | |||
|
|||
/** | |||
* @example '340,50,20' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding a @return
annotation with array
as type here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its more like string
. But I added it :)
); | ||
} | ||
|
||
public static function hslColorAsArray() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding a @return
annotation with array
as type here?
Sure thing, totally forgot about that. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you, @icanhazstring! |
This will add
hslColor
andhslColorAsArray
forColorProvider
Closes #1720