Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Add hslColor to ColorProvider #1776

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Add hslColor to ColorProvider #1776

merged 3 commits into from
Aug 27, 2019

Conversation

icanhazstring
Copy link
Contributor

@icanhazstring icanhazstring commented Aug 26, 2019

This will add hslColor and hslColorAsArray for ColorProvider

Closes #1720

This will add hslColor and hslColorAsArray for ColorProvider
Should solve #1720
Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

One more thing though before I can approve: Can you update readme.md, please?

@@ -113,4 +113,26 @@ public static function colorName()
{
return static::randomElement(static::$allColorNames);
}

/**
* @example '340,50,20'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding a @return annotation with array as type here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its more like string. But I added it :)

);
}

public static function hslColorAsArray()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding a @return annotation with array as type here?

@icanhazstring
Copy link
Contributor Author

This looks good to me!

One more thing though before I can approve: Can you update readme.md, please?

Sure thing, totally forgot about that. 👍

Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz merged commit 0c53182 into fzaninotto:master Aug 27, 2019
@localheinz
Copy link
Contributor

Thank you, @icanhazstring!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate HSL color
3 participants