This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Added some more information for autoloading in the readme #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
suggested changes
Aug 27, 2019
fzaninotto
approved these changes
Aug 27, 2019
localheinz
reviewed
Aug 27, 2019
| Use `Faker\Factory::create()` to create and initialize a faker generator, which can generate data by accessing properties named after the type of data you want. | ||
| ### Autoloading | ||
|
|
||
| Faker supports both `PSR-0` as `PSR-4` autoloaders. |
There was a problem hiding this comment.
Not sure if users care about the kind of autoloader we use internally.
Perhaps we should point out two options:
- when installed via
composer, requirevendor/autoload.php - otherwise, require
/path/to/Faker/src/autoload.php
What do you think?
There was a problem hiding this comment.
I do agree but this is a bit "as is" and i think we should not just wipe it. The focus now is on composer autoload and otherwise the custom one which is psr0.
But i would not be suprised if there are enough people around that just load it manually instead and that do not use composer yet.
localheinz
approved these changes
Aug 27, 2019
|
Thank you, @pimjansen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some more info about autoloading since there are some questions as issues on this. Since 99% of the people will install the package via composer anyways i think its more easy