This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Enhancement: Slightly clean up Company provider #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimjansen
approved these changes
Aug 29, 2019
fzaninotto
approved these changes
Sep 17, 2019
src/Faker/Provider/nl_NL/Company.php
Outdated
| $companyName = static::randomElement(static::$store) . ' ' . $lastName; | ||
| break; | ||
|
|
||
| if (0 === $determinator) { |
There was a problem hiding this comment.
what's wrong with switch / case?
There was a problem hiding this comment.
It's probably a matter of personal taste - personally I avoid to use it because
- it usually requires a lot more code
- it uses weak comparisons
But if you prefer, I can revert this change!
There was a problem hiding this comment.
Yes, I personally have nothing against switch/case, so please revert just that part
localheinz
force-pushed
the
feature/company
branch
from
32cb26e
to
42858a7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
CompanyproviderFollows #1529.
💁♂ Probably best reviewed commit by commit.