This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
typo #1789
Merged
typo #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimjansen
approved these changes
Sep 16, 2019
fzaninotto
reviewed
Sep 17, 2019
src/Faker/Provider/Uuid.php
Outdated
| @@ -10,7 +10,7 @@ class Uuid extends Base | |||
| */ | |||
| public static function uuid() | |||
| { | |||
| // fix for compatibility with 32bit architecture; seed range restricted to 62bit | |||
| // fix for compatibility with 32bit architecture; seed range restricted to 32bit | |||
There was a problem hiding this comment.
I don't understand this "seed range restricted to" comment. But concatenating two 32 bits random numbers does sound like 64 bits of randomness, not 32.
There was a problem hiding this comment.
As I understand it, it means that each mt_rand call is limited to 32 bits. Previously PHP_MAX_INT was used which produced 32 bit randomness on 32bit systems and 64 bit randomnes on 64bit systems. Two 32bit calls are used instead to produce 64bit result.
There was a problem hiding this comment.
Can you please update the comment to make it more clear?
enumag
commented
Sep 17, 2019
fzaninotto
approved these changes
Sep 17, 2019
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.