This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Enhancement: Collect code coverage #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/coverage
branch
from
c91c03e
to
15d4f3b
Compare
localheinz
changed the title
localheinz
force-pushed
the
feature/coverage
branch
from
15d4f3b
to
08911a0
Compare
localheinz
force-pushed
the
feature/coverage
branch
from
eb77e76
to
f114012
Compare
localheinz
changed the title
localheinz
force-pushed
the
feature/coverage
branch
from
7e3bb1c
to
083b046
Compare
localheinz
commented
Nov 23, 2019
| - php: 7.1 | ||
| - php: 7.2 | ||
| - php: 7.3 | ||
| env: WITH_COVERAGE=true |
There was a problem hiding this comment.
We probably do not need to collect coverage on all builds - running on the latest version of PHP increases the likelihood that it's a fast run nonetheless.
localheinz
force-pushed
the
feature/coverage
branch
from
368fdd3
to
f4e0611
Compare
Codecov Report
@@ Coverage Diff @@
## master #1824 +/- ##
=========================================
Coverage ? 56.33%
Complexity ? 2068
=========================================
Files ? 306
Lines ? 4851
Branches ? 0
=========================================
Hits ? 2733
Misses ? 2118
Partials ? 0Continue to review full report at Codecov.
|
fzaninotto
approved these changes
Nov 27, 2019
pimjansen
approved these changes
Nov 28, 2019
|
Thank you, @fzaninotto and @pimjansen! |
|
Will add this to #1847 as well! |
Partoo
added a commit
to Partoo/Faker
that referenced
this pull request
Jun 21, 2020
* 'master' of github.com:Partoo/Faker: (294 commits) Fix (bug fzaninotto#1862): Do not clear entity manager for doctrine orm populator (fzaninotto#1995) Remove persian rude words. (fzaninotto#1879) Enhancement: Run builds on master using GitHub Actions Fix typo (fzaninotto#1927) Fix: Run build against PHP 7.4 Fix: Aggregate badges in one place (fzaninotto#1866) Added changelog for the 1.9.1 release Fix: Reduce visibility of setUp() and tearDown() (fzaninotto#1821) Enhancement: Collect code coverage (fzaninotto#1824) Enhancement: Use all columns when running tests Add link to PHPStan extension to readme (fzaninotto#1834) Enhancement: Configure verbose output via phpunit.xml.dist Update master version Bump version to 1.9 Curly braces for arrays is deprecated in PHP 7.4 (detected by PHPCompatibility) Updated indenting changelog Update changelog with 1.9.0 release Skipped lorumpixel test for the release where the service is pretty unstable Fix: Mark test classes as final Fix: Remove unnecessary class-level DocBlocks ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
coveragetarget toMakefilefor collecting code coverage