Add Swedish locale #316
Add Swedish locale #316
Conversation
|
@fzaninotto |
| public function firstName($gender = null) | ||
| { | ||
| if ($gender == static::GENDER_MALE) { | ||
|
|
There was a problem hiding this comment.
Nothing, apparently =)
When finishing up this PR I noticed that another PR just got merged that already took care of differentiating male/female names: #114
I renamed my class properties to match those in that PR but missed removing the method overrides. I'll remove these overrides and just use the inherited ones.
|
@fzaninotto , @ulrikjohansson - hey guys, I see there are merge conflicts that prevent this from going into the main code. I just wanted to ping you both, or I can make an attempt to resolve the conflicts. Thanks! |
|
@undernewmanagement I suggest you coordinate efforts with @ulrikjohansson |
|
@undernewmanagement Hi! Sadly I've neglected this pull request since I stopped using Faker for the project that was intended to use this patch. I've updated the pull request now so it's mergable again, but since it's a bit old now I need to have a look through it to see if it's still ok, and then fix the things that stopped the pull request from being accepted in the first place. I think I will have some time for that this weekend. |
|
@fzaninotto I've finally gotten around to updating this pull request to use a DateTime provider in the personal number function so that the personal numbers use the seed properly. |
|
Great! Many thanks for your contribution. |
Adding Swedish localisation for personal data (names, personal identity number) as well as addresses and phone numbers.