This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
personalIdentityNumber on es_ES Person #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function personalIdentityNumber() | ||
| { | ||
| $number = rand(10000000, 99999999); |
There was a problem hiding this comment.
using rand() in Faker is prohibited; it kills seeding. Use mt_rand() instead.
Generate numbers from 100 to 99999999. Doc added.
|
Hi! I've done another pull request, I've added three urls with documentation about the number generation. The function returns a DNI with letter (NIF). Thanks! |
|
Could you add a unit test? |
|
Ok, I will add the unit test. |
|
Bump! Could you add a unit test? |
|
Sorry, I had completely forgotten. I'will try to add the unit test asap (may be this weekend). |
|
You should add a unit test and a link in the README (in the locale section). I'll close this PR within a few weeks otherwise. |
|
Superseded by #763 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Can we have the personalIdentityNumber method on es_ES Person like in sv_SE Person?
Thanks!