This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
en_GB people provider #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a more specific faker provider for UK names
| '{{firstNameFemale}} {{lastName}}', | ||
| ); | ||
|
|
||
| protected static $firstNameMale = array( |
There was a problem hiding this comment.
Please reference the data source in a phpDoc @link comment
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently found myself using Faker for some test data to provide a demonstration system and found that the names which were being generated in most cases, weren't names which are commonly used in the UK.
I've created a simple Person class for the UK.
Data for forenames came from ONS female names here and male names here - I used the data from 2003 and 2013.
I also used some of the names already in the en_US locale which were relevant to a UK audience.
For surnames, I found a list here which seemed to reflect usage well.
I haven't added any tests as I've only changed the contents of the arrays, but if there's anything else I should be doing let me know. I've not made an open source contribution before, and I wasn't entirely sure if I should be submitting this as none of the other EN locales have specific Person providers (other than the default en_GB).