This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Realtext provider #434
Merged
Realtext provider #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis test failed in HHVM only and the error message is:
/home/travis/build/fzaninotto/Faker/test/Faker/Provider/DateTimeTest.php:119 FAILURES! Since the DateTime provider is not touched in this PR, I am not sure where the issue is. Could you please give me some advise for that? Thanks. |
|
Probably a random failure due to an advancing clock... |
|
|
||
| protected static function strlen($text) | ||
| { | ||
| return function_exists('mb_strlen') ? mb_strlen($text, 'UTF-8') : count(static::split($text)); |
There was a problem hiding this comment.
static::split() doesn't seem to exist. Do you mean static::explode()?
There was a problem hiding this comment.
Oh, you are right. Fixed now.
|
I re-triggered Travis, and it seems to pass now. |
|
Thanks a lot! |
|
Thanks! :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the base realText provider and provides the instance for zh_TW locale.